fix: Complex test name normalization #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for working on this @flohw! Let me know when it's ready and I'll merge! |
|
Hi @kbond, Chocolate activates some neurons! I added the regex group names to be more comprehensible. Also I updated the preg_replace to replace multiple non-word characters by a single hyphen to shorten the filename a bit. For example for the dataset Let me know if I need to make changes you have in mind. Have a nice week-end! |
|
Thanks @flohw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As a Christmas gift I come here to preset the work to hopefully close #67 properly 🎅 🥳
I added the cases suggested by @0x346e3730 based on the existing test cases of @raneomik.
Let me know if the new algorithm is ok for you.
The regexes are a bit stricter as there is
with data setinto, that's why I return early on line 117. It make the regexes a bit easier to read I think. That's not perfect to my eyes (depending on a static string is not algorithmically valid to me) but it may be enough. WDYT?I will also create named group to make the code clearer.
I didn't set cases stated by er1z in the issue as he didn't explain much about its problem.
If you look at it during this long weekend, please don't merge. I wanted to sign my commits but I have some issue with my passphrase memory 😅
Thanks and have a nice week-end!
[EDIT]: Failing test seems unrelated.